continue

cross_eval/config.py

@@ -31,7 +31,10 @@ DEFAULT_ROLE_REASONING_EFFORTS = {
     "reviewer": "medium",
     "senior": "high",
 }
-FIX_STYLE_PRESETS = {"plan-review", "review-fix", "coding-review-fix"}
+FIX_STYLE_PRESETS = {
+    "plan-review",
+    "coding-plan-review",
+}
 
 
 # ---------------------------------------------------------------------------
@@ -298,8 +301,7 @@ def _default_seniors_for_preset(
         isinstance(pipeline_raw, str)
         and pipeline_raw in {
             "preset:plan-review",
-            "preset:review-fix",
-            "preset:coding-review-fix",
+            "preset:coding-plan-review",
         }
         and reviewers
     ):
@@ -382,9 +384,11 @@ def default_config() -> PipelineConfig:
     coders = ["claude-coder"]
     reviewers = ["claude-reviewer"]
     seniors: list[str] = []
-    pipeline = PIPELINE_PRESETS["simple"](coders, reviewers, seniors)
+    pipeline: list[StepConfig] = []
+    phases = PHASED_PRESETS["coding-plan-review"](coders, reviewers, seniors)
     return PipelineConfig(
         output_dir=Path(".cross-eval/output"),
+        use_worktree=False,
         max_iterations=3,
         language="ko",
         execution=ExecutionConfig(),
@@ -394,6 +398,8 @@ def default_config() -> PipelineConfig:
         reviewers=reviewers,
         seniors=seniors,
         pipeline=pipeline,
+        phases=phases,
+        preset_name="coding-plan-review",
     )
 
 
@@ -437,7 +443,7 @@ def _parse_raw(raw: dict[str, Any], config_path: Path) -> PipelineConfig:
         )
 
     # --- roles: explicit or inferred ---
-    pipeline_raw = raw.get("pipeline", "preset:simple")
+    pipeline_raw = raw.get("pipeline", "preset:coding-plan-review")
     coders_raw = raw.get("coders")
     reviewers_raw = raw.get("reviewers")
     seniors_raw = raw.get("seniors")
@@ -498,6 +504,7 @@ def _parse_raw(raw: dict[str, Any], config_path: Path) -> PipelineConfig:
 
     config = PipelineConfig(
         output_dir=output_dir,
+        use_worktree=bool(raw.get("use_worktree", False)),
         max_iterations=int(raw.get("max_iterations", 3)),
         min_iterations=int(raw.get("min_iterations", 1)),
         verbose=bool(raw.get("verbose", False)),
@@ -555,10 +562,10 @@ def _resolve_pipeline(
     """Resolve pipeline from preset string or explicit step list.
 
     Returns (steps, phases) tuple.  Only one will be non-empty.
-    - Simple/cross-review/plan-review/review-only → steps populated, phases empty.
-    - Phased presets (review-fix) → steps empty, phases populated.
+    - plan-review → steps populated, phases empty.
+    - coding-plan-review → steps empty, phases populated.
     """
-    # Preset: "preset:simple" or "preset:review-fix"
+    # Preset: "preset:plan-review" or "preset:coding-plan-review"
     if isinstance(pipeline_raw, str) and pipeline_raw.startswith("preset:"):
         preset_name = pipeline_raw.split(":", 1)[1]
         if preset_name in PIPELINE_PRESETS:
@@ -592,7 +599,7 @@ def _resolve_pipeline(
         return steps, []
 
     raise ValueError(
-        f"'pipeline' must be a preset string (e.g. 'preset:simple') "
+        f"'pipeline' must be a preset string (e.g. 'preset:plan-review') "
         f"or a list of step definitions, got {type(pipeline_raw).__name__}"
     )