feat(my-deepagent): v0.2 PR #3 — FastAPI + SSE + minimal Web GUI (mydeepagent serve)
Closes the "GUI 미존재" gap from the user's first-session requirements (REPL + workflow + GUI). v0.2 PR #1's Postgres migration made a second concurrent writer safe; v0.2 PR #2a/#2b wired durable resume; this commit ships the HTTP + browser surface that uses them. No auth, no multi-tenant, single uvicorn worker — per DR-3 boundaries. v0.3+ will add auth, multi-worker fanout, LISTEN/NOTIFY SSE upgrade. Backend - `src/my_deepagent/api/`: - `app.py` create_app() factory. lifespan stores db/config/personas/ workflows on app.state. CORS allow_origin_regex http://localhost(:port)?. /static mount + /, /{page}.html for the HTML frontend. - `models.py` — pydantic v2 DTOs (extra="forbid") for every route. Auto OpenAPI/Swagger via FastAPI's response_model. - `deps.py` — get_db / get_config / get_personas / get_workflows. - `runner.py` — start_new_run / start_resume. Pre-allocates run_id via new `WorkflowEngine.run(pre_allocated_run_id=...)` so the route returns the id immediately while the engine runs in asyncio.create_task. - `sse.py` — 0.5 s poll over run_events.seq. Emits ServerSentEvent rows; sends `event: done` and HTTP-200-closes when run hits terminal. - `routes/{runs,personas,workflows,budget}.py`: GET /api/runs (list, ?limit + ?state) GET /api/runs/{id} (detail + phases + artifacts + events) POST /api/runs (start; mock-able via runner.start_new_run) POST /api/runs/{id}/resume POST /api/runs/{id}/abort GET /api/runs/{id}/events (SSE; Last-Event-ID header + ?last_event_id) GET /api/personas GET /api/workflows GET /api/budget CLI - `cli/serve.py` mydeepagent serve [--host 127.0.0.1] [--port 8000]. Loud stderr warning if --host is not loopback (no auth = footgun). uvicorn.run(factory=True, workers=1). - `cli/main.py` serve command registered. Static frontend (vanilla HTML/JS/CSS, no build system) - index.html — runs list + budget summary - new.html — start-run form (workflow select, repo path, requirements, per-role persona override) - run.html — run detail + live SSE event log + Resume/Abort buttons - app.js — fetch + EventSource. XSS policy HARDCODED at file top: textContent only, innerHTML/insertAdjacentHTML/outerHTML forbidden. - style.css — dark theme, single file. Engine - WorkflowEngine.run(... pre_allocated_run_id: UUID|None = None). None → uuid4() (existing behavior). Set → use that UUID. Backward compatible. Tests - tests/integration/test_api_read.py (5): list empty, get 404, personas seed count (12), workflows seed (>=3), budget empty. - tests/integration/test_api_write.py (5): missing template 400, extra field 422, resume 404, abort 404, mock-runner happy path. - tests/integration/test_api_sse.py (1): seed terminal run + 3 events, drain stream, assert types present + stream closes within 3 s. - tests/integration/test_api_static.py (5): index/new/run HTML 200, app.js content-type + XSS-policy substring assertion, style.css content-type. - All fixtures use httpx ASGITransport + app.router.lifespan_context (httpx does NOT auto-trigger FastAPI lifespan) + sqlite tmp_path. Gates - ruff check + ruff format --check + mypy --strict: PASS (120 source files) - pytest non-E2E: 603 PASS (12.15 s) — +16 from new API tests - pytest E2E real OpenRouter on Postgres: PASS 60.44 s (baseline 71–122 s range; well within DR-3 acceptance threshold ≤+20%) Manual browser verification deferred to a follow-up (docker compose up, mydeepagent serve, open http://localhost:8000). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
chungyeong
119
my-deepagent/tests/integration/test_api_write.py
Normal file
119
my-deepagent/tests/integration/test_api_write.py
Normal file
@@ -0,0 +1,119 @@
|
||||
"""POST /api/runs + /api/runs/{id}/resume + /api/runs/{id}/abort — D2 write routes."""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from collections.abc import AsyncIterator
|
||||
from pathlib import Path
|
||||
from unittest.mock import AsyncMock, patch
|
||||
|
||||
import pytest
|
||||
from httpx import ASGITransport, AsyncClient
|
||||
|
||||
from my_deepagent.api.app import create_app
|
||||
from my_deepagent.config import load_config
|
||||
from my_deepagent.persistence.db import Database
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
async def app_client(tmp_path: Path) -> AsyncIterator[AsyncClient]:
|
||||
db_url = f"sqlite+aiosqlite:///{tmp_path / 'api_write.sqlite3'}"
|
||||
cfg = load_config(
|
||||
workspace_root=tmp_path,
|
||||
data_dir=tmp_path / "data",
|
||||
database_url=db_url,
|
||||
)
|
||||
db = Database(db_url)
|
||||
await db.init_schema()
|
||||
await db.dispose()
|
||||
app = create_app(cfg)
|
||||
transport = ASGITransport(app=app)
|
||||
async with app.router.lifespan_context(app):
|
||||
async with AsyncClient(transport=transport, base_url="http://test") as client:
|
||||
yield client
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# POST /api/runs validation
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_start_run_missing_template_returns_400(
|
||||
app_client: AsyncClient, tmp_path: Path
|
||||
) -> None:
|
||||
r = await app_client.post(
|
||||
"/api/runs",
|
||||
json={
|
||||
"template_path": "/this/does/not/exist.yaml",
|
||||
"repo_path": str(tmp_path),
|
||||
"base_branch": "main",
|
||||
"requirements_md": "test",
|
||||
},
|
||||
)
|
||||
assert r.status_code == 400
|
||||
assert "not found" in r.json()["detail"]
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_start_run_extra_field_returns_422(app_client: AsyncClient, tmp_path: Path) -> None:
|
||||
r = await app_client.post(
|
||||
"/api/runs",
|
||||
json={
|
||||
"template_path": "spec-and-review@1.yaml",
|
||||
"repo_path": str(tmp_path),
|
||||
"rogue_field": "should-fail",
|
||||
},
|
||||
)
|
||||
# pydantic extra=forbid → 422 unprocessable entity
|
||||
assert r.status_code == 422
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# POST /api/runs/{id}/resume — 404 + 409
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_resume_unknown_run_404(app_client: AsyncClient) -> None:
|
||||
r = await app_client.post("/api/runs/00000000-0000-0000-0000-000000000000/resume")
|
||||
assert r.status_code == 404
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# POST /api/runs/{id}/abort — 404 + 409
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_abort_unknown_run_404(app_client: AsyncClient) -> None:
|
||||
r = await app_client.post("/api/runs/00000000-0000-0000-0000-000000000000/abort")
|
||||
assert r.status_code == 404
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# POST /api/runs success — mock the runner so we don't actually invoke OpenRouter
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_start_run_success_returns_run_id(app_client: AsyncClient, tmp_path: Path) -> None:
|
||||
from uuid import UUID
|
||||
|
||||
fake_run_id = UUID("11111111-2222-3333-4444-555555555555")
|
||||
with patch(
|
||||
"my_deepagent.api.routes.runs.runner.start_new_run",
|
||||
new=AsyncMock(return_value=fake_run_id),
|
||||
):
|
||||
r = await app_client.post(
|
||||
"/api/runs",
|
||||
json={
|
||||
"template_path": "spec-and-review@1.yaml",
|
||||
"repo_path": str(tmp_path),
|
||||
"base_branch": "main",
|
||||
"requirements_md": "x",
|
||||
},
|
||||
)
|
||||
assert r.status_code == 200
|
||||
body = r.json()
|
||||
assert body["run_id"] == str(fake_run_id)
|
||||
assert body["state"] == "executing"
|
||||
Reference in New Issue
Block a user