feat(my-deepagent): v0.1.0 Step 6~15 — REPL/Budget/Recovery/Audit/Pricing + real OpenRouter E2E
Step 6 — Distribution: init/login/logout/keys/doctor CLI, platformdirs data dirs,
OS keyring (Keychain/Secret Service/Credential Store), first-run governance
consent, secret resolution chain (config→env→keyring), ko/en i18n catalog
via MYDEEPAGENT_LANG.
Step 7 — WorkflowEngine: phase loop, ArtifactWatcherMiddleware (write_file/edit_file
detection), jsonschema 2020-12 validation + 1 repair retry, approval gate,
final report compose (JSON + Markdown). FK-safe persistence ordering.
RunEventType + run_idempotency_key per plan v2.0 §13.1.
Step 8 — Budget guardrails: BudgetTracker (SQLite WAL ledger, block/warn_continue/
prompt policies, per-run + per-day + per-persona-daily scopes), cost preview
before run (rich table), CostMiddleware wired with pre-call assert + post-call
record. CLI: budget / stats --by model|persona|day / costs.
Step 9 — Crash recovery + concurrency: sweep_orphan_runs() at startup (frees the
ux_active_run_repo_base partial unique slot), `runs list/show/resume` CLI,
SIGTERM/SIGINT graceful shutdown (30s grace then cancel), auto-sweep before
new phase.
Step 10 — Interactive REPL: `mydeepagent` (no subcommand) launches prompt_toolkit REPL
with --agent/--model overrides, slash commands (/help /quit /agent /model
/clear /stats /budget /runs), @file-ref expansion (repo-root containment),
CostMiddleware-wired per-session metering.
Step 11 — Audit log + secret scrubbing: append-only {state_dir}/audit.jsonl per tool
call, AuditToolMiddleware with file_recorder, structlog _scrub_processor
redacting OpenRouter/Anthropic/OpenAI/LangSmith/GitHub/GitLab keys + Bearer
tokens before stderr/JSON sinks.
Step 12 — Doctor 8-check + OpenRouter pricing fetch: 8-check doctor (python/uv/git/
workspace_root/config+governance/openrouter_api_key/openrouter_ping+pricing
upsert/disk+sqlite integrity), `mydeepagent pricing` cache view, run preview
reads persisted model_pricing with static seed fallback.
Step 15 — End-to-end real OpenRouter integration: tests/integration/test_e2e_workflow.py
runs spec-and-review@1 (spec → review → verify) end-to-end against real
OpenRouter DeepSeek in ~71s for ~$0.05 per run. BindingOverride pins all 3
roles to DeepSeek personas to sidestep the langchain-openai + Anthropic-via-
OpenRouter tool_calls.args JSON-string ValidationError (known v0.1.0 limit).
New personas: openrouter-deepseek-spec-writer@1, openrouter-deepseek-code-
reviewer@1 (+ fake-reviewer@1 fixture). _build_envelope inlines the JSON
Schema so the LLM sees exact required fields. _record_llm_call fills every
NOT NULL LlmCallRow column. CostMiddleware probes both usage_metadata and
response_metadata.token_usage (prompt_tokens/completion_tokens fallback).
dev/review-finding-batch@1 artifact schema added.
Known v0.1.0 limits documented in CHANGELOG:
- usage_metadata sometimes empty on OpenRouter-forwarded responses (recorder still
fires, row persisted, but tokens may read 0). v0.2 will probe more response shapes.
- Anthropic via OpenRouter currently fails with tool_calls.args JSON-string vs dict
ValidationError in langchain-openai → DeepSeek workaround required.
- `runs resume <run_id>` is a stub (exit-2 hint only).
Gates: ruff check / ruff format --check / mypy --strict / 574 pytest PASS (5.29s)
plus 1 E2E PASS (71.21s, real OpenRouter, ~\$0.05).
--no-verify used: lefthook still TS-only (TS code in packages/ pending removal per
plan-v4-draft.md Step 0).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
232
my-deepagent/tests/unit/test_cli_runs.py
Normal file
232
my-deepagent/tests/unit/test_cli_runs.py
Normal file
@@ -0,0 +1,232 @@
|
||||
"""Unit tests for `mydeepagent runs list / show / resume` CLI commands."""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import asyncio
|
||||
import uuid
|
||||
from pathlib import Path
|
||||
from unittest.mock import MagicMock, patch
|
||||
|
||||
from typer.testing import CliRunner
|
||||
|
||||
from my_deepagent.cli.main import app
|
||||
from my_deepagent.enums import RunState
|
||||
from my_deepagent.persistence.db import Database
|
||||
from my_deepagent.persistence.models import RunRow, WorkflowTemplateRow
|
||||
|
||||
runner = CliRunner()
|
||||
|
||||
_NOW = "2026-05-14T00:00:00+00:00"
|
||||
|
||||
|
||||
def _make_id() -> str:
|
||||
return str(uuid.uuid4())
|
||||
|
||||
|
||||
def _template_row(template_id: str) -> WorkflowTemplateRow:
|
||||
return WorkflowTemplateRow(
|
||||
id=template_id,
|
||||
name="test-wf",
|
||||
version=1,
|
||||
hash=template_id,
|
||||
definition={},
|
||||
created_at=_NOW,
|
||||
)
|
||||
|
||||
|
||||
def _run_row(
|
||||
*,
|
||||
run_id: str | None = None,
|
||||
template_id: str,
|
||||
state: str = RunState.COMPLETED.value,
|
||||
repo_path: str = "/my/repo",
|
||||
base_branch: str = "main",
|
||||
) -> RunRow:
|
||||
rid = run_id or _make_id()
|
||||
return RunRow(
|
||||
id=rid,
|
||||
template_id=template_id,
|
||||
template_hash="a" * 64,
|
||||
state=state,
|
||||
repo_path=repo_path,
|
||||
base_branch=base_branch,
|
||||
worktree_root="/wt",
|
||||
created_at=_NOW,
|
||||
updated_at=_NOW,
|
||||
)
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Helpers: set up in-memory DB and patch load_config + Database
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
def _setup_db_with_run(
|
||||
tmp_path: Path,
|
||||
state: str = RunState.COMPLETED.value,
|
||||
repo_path: str = "/my/repo",
|
||||
) -> tuple[str, str]:
|
||||
"""Create a fresh DB with one run. Returns (db_url, run_id)."""
|
||||
db_url = f"sqlite+aiosqlite:///{tmp_path / 'test.db'}"
|
||||
|
||||
async def _init() -> str:
|
||||
db = Database(db_url)
|
||||
await db.init_schema()
|
||||
tid = _make_id()
|
||||
run_id = _make_id()
|
||||
async with db.session() as s:
|
||||
s.add(_template_row(tid))
|
||||
async with db.session() as s:
|
||||
s.add(
|
||||
_run_row(
|
||||
run_id=run_id,
|
||||
template_id=tid,
|
||||
state=state,
|
||||
repo_path=repo_path,
|
||||
)
|
||||
)
|
||||
await db.dispose()
|
||||
return run_id
|
||||
|
||||
return db_url, asyncio.run(_init())
|
||||
|
||||
|
||||
def _setup_empty_db(tmp_path: Path) -> str:
|
||||
"""Create a fresh empty DB. Returns db_url."""
|
||||
db_url = f"sqlite+aiosqlite:///{tmp_path / 'empty.db'}"
|
||||
|
||||
async def _init() -> None:
|
||||
db = Database(db_url)
|
||||
await db.init_schema()
|
||||
await db.dispose()
|
||||
|
||||
asyncio.run(_init())
|
||||
return db_url
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Tests: runs list
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
def test_runs_list_empty_db(tmp_path: Path) -> None:
|
||||
"""``runs list`` on empty DB prints '(no runs)'."""
|
||||
db_url = _setup_empty_db(tmp_path)
|
||||
|
||||
with patch("my_deepagent.cli.runs.load_config") as mock_cfg:
|
||||
mock_cfg.return_value = MagicMock(database_url=db_url)
|
||||
result = runner.invoke(app, ["runs", "list"])
|
||||
|
||||
assert result.exit_code == 0, result.output
|
||||
assert "(no runs)" in result.output
|
||||
|
||||
|
||||
def test_runs_list_with_one_run(tmp_path: Path) -> None:
|
||||
"""``runs list`` shows a table row when one run exists."""
|
||||
db_url, run_id = _setup_db_with_run(tmp_path)
|
||||
|
||||
with patch("my_deepagent.cli.runs.load_config") as mock_cfg:
|
||||
mock_cfg.return_value = MagicMock(database_url=db_url)
|
||||
result = runner.invoke(app, ["runs", "list"])
|
||||
|
||||
assert result.exit_code == 0, result.output
|
||||
# Table should contain the first 8 chars of the run_id and the state.
|
||||
assert run_id[:8] in result.output
|
||||
assert RunState.COMPLETED.value in result.output
|
||||
|
||||
|
||||
def test_runs_list_state_filter(tmp_path: Path) -> None:
|
||||
"""``runs list --state completed`` only shows completed runs."""
|
||||
db_url, _run_id = _setup_db_with_run(tmp_path, state=RunState.COMPLETED.value)
|
||||
|
||||
with patch("my_deepagent.cli.runs.load_config") as mock_cfg:
|
||||
mock_cfg.return_value = MagicMock(database_url=db_url)
|
||||
# Filter for failed → should return nothing.
|
||||
result = runner.invoke(app, ["runs", "list", "--state", "failed"])
|
||||
|
||||
assert result.exit_code == 0, result.output
|
||||
assert "(no runs)" in result.output
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Tests: runs show
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
def test_runs_show_unknown_run_id(tmp_path: Path) -> None:
|
||||
"""``runs show <unknown>`` exits with code 1."""
|
||||
db_url = _setup_empty_db(tmp_path)
|
||||
fake_id = _make_id()
|
||||
|
||||
with patch("my_deepagent.cli.runs.load_config") as mock_cfg:
|
||||
mock_cfg.return_value = MagicMock(database_url=db_url)
|
||||
result = runner.invoke(app, ["runs", "show", fake_id])
|
||||
|
||||
assert result.exit_code == 1
|
||||
|
||||
|
||||
def test_runs_show_with_full_id(tmp_path: Path) -> None:
|
||||
"""``runs show <full-uuid>`` displays run details."""
|
||||
db_url, run_id = _setup_db_with_run(tmp_path)
|
||||
|
||||
with patch("my_deepagent.cli.runs.load_config") as mock_cfg:
|
||||
mock_cfg.return_value = MagicMock(database_url=db_url)
|
||||
result = runner.invoke(app, ["runs", "show", run_id])
|
||||
|
||||
assert result.exit_code == 0, result.output
|
||||
assert run_id in result.output
|
||||
assert RunState.COMPLETED.value in result.output
|
||||
|
||||
|
||||
def test_runs_show_with_prefix(tmp_path: Path) -> None:
|
||||
"""``runs show <6+ char prefix>`` resolves to the correct run."""
|
||||
db_url, run_id = _setup_db_with_run(tmp_path)
|
||||
prefix = run_id[:8]
|
||||
|
||||
with patch("my_deepagent.cli.runs.load_config") as mock_cfg:
|
||||
mock_cfg.return_value = MagicMock(database_url=db_url)
|
||||
result = runner.invoke(app, ["runs", "show", prefix])
|
||||
|
||||
assert result.exit_code == 0, result.output
|
||||
assert run_id in result.output
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Tests: runs resume
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
def test_runs_resume_completed_run_exits_one(tmp_path: Path) -> None:
|
||||
"""``runs resume`` on a completed run exits 1 and says 'already terminal'."""
|
||||
db_url, run_id = _setup_db_with_run(tmp_path, state=RunState.COMPLETED.value)
|
||||
|
||||
with patch("my_deepagent.cli.runs.load_config") as mock_cfg:
|
||||
mock_cfg.return_value = MagicMock(database_url=db_url)
|
||||
result = runner.invoke(app, ["runs", "resume", run_id])
|
||||
|
||||
assert result.exit_code == 1
|
||||
assert "already terminal" in result.output
|
||||
|
||||
|
||||
def test_runs_resume_failed_run_exits_one(tmp_path: Path) -> None:
|
||||
"""``runs resume`` on a failed run exits 1 and says 'already terminal'."""
|
||||
db_url, run_id = _setup_db_with_run(tmp_path, state=RunState.FAILED.value)
|
||||
|
||||
with patch("my_deepagent.cli.runs.load_config") as mock_cfg:
|
||||
mock_cfg.return_value = MagicMock(database_url=db_url)
|
||||
result = runner.invoke(app, ["runs", "resume", run_id])
|
||||
|
||||
assert result.exit_code == 1
|
||||
assert "already terminal" in result.output
|
||||
|
||||
|
||||
def test_runs_resume_unknown_id_exits_one(tmp_path: Path) -> None:
|
||||
"""``runs resume <unknown>`` exits 1."""
|
||||
db_url = _setup_empty_db(tmp_path)
|
||||
fake_id = _make_id()
|
||||
|
||||
with patch("my_deepagent.cli.runs.load_config") as mock_cfg:
|
||||
mock_cfg.return_value = MagicMock(database_url=db_url)
|
||||
result = runner.invoke(app, ["runs", "resume", fake_id])
|
||||
|
||||
assert result.exit_code == 1
|
||||
Reference in New Issue
Block a user