fix(my-deepagent): v0.3 plan-conformance — 18-item gap fix across PR #2-#9

1차 v0.3 구현 후 plan-v0.3 와 대조해 발견된 18건 누락/명세 위반을 보강.
자기 리뷰 3 라운드 (누락·미완 / 오류·엣지케이스 / 과최적화) 모두 PASS.

PR #5 plan-mode (3건):
- BLOCKED_TOOLS_IN_PLAN_MODE 에 write_todos 추가
- /plan 시 system message inject (_PLAN_MODE_SYSTEM_PROMPT)
- /approve 시 마지막 assistant 메시지를 "approved plan" system 으로 inject
- InteractiveSession._pending_system_messages 인프라 신설

PR #2 compaction (1건):
- CompactionResult.summary_text 추가, 다음 thread 첫 ainvoke 에 inject

PR #3 auto-memory (6건):
- global memory dir + bootstrap
- frontmatter name/description/type 정식 도입 + MemoryEntry/MemoryType
- _infer_memory_type (keyword heuristic, no LLM)
- _scrub_secrets (OpenRouter/Anthropic/OpenAI/AWS/Bearer redaction)
- /memory show <name> 서브명령
- /remember [--global] / /forget [--global] 스코프 토글

PR #4 skills (3건):
- project_skills_dir + 두 스코프 (global / project) merge with last-wins
- /skill <name> 본문 inject (queue_system_message) — 이전엔 REPL 출력만
- /skills show <name> 별도 서브명령

PR #6 sub-agent (4건):
- budget.py `session:<uuid>` scope + CostMiddleware 자동 전달
- resolve_root_session_id walk-up (cycle guard) + sub-agent root 에 charge
- run_subagent_to_completion 실제 ainvoke + 결과 push to parent
- /agents 서브명령 구조 (list / spawn / show) + spawn 시 parent system msg

PR #7 governance (1건):
- bootstrap_user_dirs — instructions + global/memory + skills + projects 한
  호출로 idempotent 부트스트랩

PR #8 Web GUI (1건):
- index.html → 세션 목록, runs.html (신설) → workflow archive
- conversation.html ?session=<id> deep-link

PR #9 workflow integration (2건):
- /workflow 백그라운드 WorkflowEngine.run + 진행 메시지 stream 누적
- /binding show <workflow-name[@version]> 인자 지원

테스트 (+17, 685 → 702 passed):
- test_plan_mode: write_todos 차단 + blocklist sanity
- test_memory: scrub + type 추론 + override
- test_skills: project override + find_skill + resolve_skill_sources(pk)
- test_subagents: resolve_root_session_id chain + missing fallback
- test_budget: session: scope accumulation
- test_instructions: governance bootstrap + idempotency
- test_api_static: runs.html 신설 + index.html 재구성

게이트:
- ruff check / format --check / mypy: PASS (141 source files)
- pytest -q --ignore=tests/integration/test_e2e_workflow.py
  --ignore=tests/integration/test_openrouter_smoke.py: 702 passed

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
chungyeong
2026-05-18 00:03:08 +09:00
parent 361d6d7636
commit 96c8849e2c
24 changed files with 1687 additions and 304 deletions

View File

@@ -71,23 +71,25 @@ def test_ensure_memory_initialized_is_idempotent(memory_dir: Path) -> None:
def test_add_memory_entry_writes_file_and_updates_index(memory_dir: Path) -> None:
path = add_memory_entry(memory_dir, "프로젝트 핵심: 위크닥 CLI MVP")
assert path.is_file()
body = path.read_text(encoding="utf-8")
result = add_memory_entry(memory_dir, "프로젝트 핵심: 위크닥 CLI MVP")
assert result.path.is_file()
body = result.path.read_text(encoding="utf-8")
assert "프로젝트 핵심" in body
assert body.startswith("---\nslug: ")
assert body.startswith("---\nname: ")
assert "type:" in body
assert result.scrubbed is False
index = (memory_dir / INDEX_FILENAME).read_text(encoding="utf-8")
assert path.name in index
assert result.path.name in index
assert "프로젝트 핵심" in index
def test_add_memory_entry_handles_slug_collision(memory_dir: Path) -> None:
p1 = add_memory_entry(memory_dir, "Same first line")
p2 = add_memory_entry(memory_dir, "Same first line\nsecond entry body")
p3 = add_memory_entry(memory_dir, "Same first line\nthird entry body")
r1 = add_memory_entry(memory_dir, "Same first line")
r2 = add_memory_entry(memory_dir, "Same first line\nsecond entry body")
r3 = add_memory_entry(memory_dir, "Same first line\nthird entry body")
p1, p2, p3 = r1.path, r2.path, r3.path
assert p1.name != p2.name != p3.name
# Auto-slugging should land on <slug>-2.md and <slug>-3.md.
stems = sorted([p1.stem, p2.stem, p3.stem])
assert stems[0] == "same-first-line"
assert stems[1] == "same-first-line-2"
@@ -100,8 +102,34 @@ def test_add_memory_entry_rejects_empty_content(memory_dir: Path) -> None:
def test_add_memory_entry_explicit_name_override(memory_dir: Path) -> None:
p = add_memory_entry(memory_dir, "Random body text", name="My Custom Slug!!")
assert p.stem == "my-custom-slug"
r = add_memory_entry(memory_dir, "Random body text", name="My Custom Slug!!")
assert r.path.stem == "my-custom-slug"
def test_add_memory_entry_scrubs_openrouter_key(memory_dir: Path) -> None:
r = add_memory_entry(
memory_dir,
"save this for me: sk-or-v1-abcdefghijklmnop1234567890",
)
body = r.path.read_text(encoding="utf-8")
assert "sk-or-v1-abcdefghijklmnop" not in body
assert "<redacted:openrouter-key>" in body
assert r.scrubbed is True
def test_add_memory_entry_infers_user_type(memory_dir: Path) -> None:
r = add_memory_entry(memory_dir, "I prefer fish shell over bash")
assert r.memory_type == "user"
def test_add_memory_entry_infers_feedback_type(memory_dir: Path) -> None:
r = add_memory_entry(memory_dir, "don't mock the database in integration tests")
assert r.memory_type == "feedback"
def test_add_memory_entry_explicit_type_overrides_heuristic(memory_dir: Path) -> None:
r = add_memory_entry(memory_dir, "I prefer fish shell", memory_type="reference")
assert r.memory_type == "reference"
# ---------------------------------------------------------------------------
@@ -110,17 +138,17 @@ def test_add_memory_entry_explicit_name_override(memory_dir: Path) -> None:
def test_remove_memory_entry_by_slug(memory_dir: Path) -> None:
p = add_memory_entry(memory_dir, "to be forgotten")
assert remove_memory_entry(memory_dir, p.stem) is True
assert not p.exists()
r = add_memory_entry(memory_dir, "to be forgotten")
assert remove_memory_entry(memory_dir, r.path.stem) is True
assert not r.path.exists()
index_body = (memory_dir / INDEX_FILENAME).read_text(encoding="utf-8")
assert p.name not in index_body
assert r.path.name not in index_body
def test_remove_memory_entry_by_filename(memory_dir: Path) -> None:
p = add_memory_entry(memory_dir, "to be forgotten by full filename")
assert remove_memory_entry(memory_dir, p.name) is True
assert not p.exists()
r = add_memory_entry(memory_dir, "to be forgotten by full filename")
assert remove_memory_entry(memory_dir, r.path.name) is True
assert not r.path.exists()
def test_remove_memory_entry_missing_returns_false(memory_dir: Path) -> None: