fix(my-deepagent): v0.3 plan-conformance — 18-item gap fix across PR #2-#9

1차 v0.3 구현 후 plan-v0.3 와 대조해 발견된 18건 누락/명세 위반을 보강.
자기 리뷰 3 라운드 (누락·미완 / 오류·엣지케이스 / 과최적화) 모두 PASS.

PR #5 plan-mode (3건):
- BLOCKED_TOOLS_IN_PLAN_MODE 에 write_todos 추가
- /plan 시 system message inject (_PLAN_MODE_SYSTEM_PROMPT)
- /approve 시 마지막 assistant 메시지를 "approved plan" system 으로 inject
- InteractiveSession._pending_system_messages 인프라 신설

PR #2 compaction (1건):
- CompactionResult.summary_text 추가, 다음 thread 첫 ainvoke 에 inject

PR #3 auto-memory (6건):
- global memory dir + bootstrap
- frontmatter name/description/type 정식 도입 + MemoryEntry/MemoryType
- _infer_memory_type (keyword heuristic, no LLM)
- _scrub_secrets (OpenRouter/Anthropic/OpenAI/AWS/Bearer redaction)
- /memory show <name> 서브명령
- /remember [--global] / /forget [--global] 스코프 토글

PR #4 skills (3건):
- project_skills_dir + 두 스코프 (global / project) merge with last-wins
- /skill <name> 본문 inject (queue_system_message) — 이전엔 REPL 출력만
- /skills show <name> 별도 서브명령

PR #6 sub-agent (4건):
- budget.py `session:<uuid>` scope + CostMiddleware 자동 전달
- resolve_root_session_id walk-up (cycle guard) + sub-agent root 에 charge
- run_subagent_to_completion 실제 ainvoke + 결과 push to parent
- /agents 서브명령 구조 (list / spawn / show) + spawn 시 parent system msg

PR #7 governance (1건):
- bootstrap_user_dirs — instructions + global/memory + skills + projects 한
  호출로 idempotent 부트스트랩

PR #8 Web GUI (1건):
- index.html → 세션 목록, runs.html (신설) → workflow archive
- conversation.html ?session=<id> deep-link

PR #9 workflow integration (2건):
- /workflow 백그라운드 WorkflowEngine.run + 진행 메시지 stream 누적
- /binding show <workflow-name[@version]> 인자 지원

테스트 (+17, 685 → 702 passed):
- test_plan_mode: write_todos 차단 + blocklist sanity
- test_memory: scrub + type 추론 + override
- test_skills: project override + find_skill + resolve_skill_sources(pk)
- test_subagents: resolve_root_session_id chain + missing fallback
- test_budget: session: scope accumulation
- test_instructions: governance bootstrap + idempotency
- test_api_static: runs.html 신설 + index.html 재구성

게이트:
- ruff check / format --check / mypy: PASS (141 source files)
- pytest -q --ignore=tests/integration/test_e2e_workflow.py
  --ignore=tests/integration/test_openrouter_smoke.py: 702 passed

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
chungyeong
2026-05-18 00:03:08 +09:00
parent 361d6d7636
commit 96c8849e2c
24 changed files with 1687 additions and 304 deletions

View File

@@ -201,6 +201,66 @@ def test_resolve_skill_sources_returns_user_dir(tmp_path: Path) -> None:
assert sources[0] == str(user_skills_dir(cfg).resolve())
def test_resolve_skill_sources_with_project_key_returns_both(tmp_path: Path) -> None:
from my_deepagent.skills import project_skills_dir
cfg = load_config(workspace_root=tmp_path, data_dir=tmp_path / "data")
sources = resolve_skill_sources(cfg, project_key="proj1234abcdef00")
assert sources == [
str(user_skills_dir(cfg).resolve()),
str(project_skills_dir(cfg, "proj1234abcdef00").resolve()),
]
def test_list_all_skills_project_overrides_global(tmp_path: Path) -> None:
from my_deepagent.skills import list_all_skills, project_skills_dir
cfg = load_config(workspace_root=tmp_path, data_dir=tmp_path / "data")
pk = "abc123def456ffff"
global_dir = user_skills_dir(cfg)
proj_dir = project_skills_dir(cfg, pk)
global_dir.mkdir(parents=True)
proj_dir.mkdir(parents=True)
_make_skill(global_dir, "shared", description="global-version")
_make_skill(proj_dir, "shared", description="project-version")
_make_skill(global_dir, "global-only", description="g")
_make_skill(proj_dir, "project-only", description="p")
skills = list_all_skills(cfg, pk)
by_name = {s.name: s for s in skills}
assert set(by_name.keys()) == {"shared", "global-only", "project-only"}
# Project overrides global on the shared name.
assert by_name["shared"].scope == "project"
assert by_name["shared"].description == "project-version"
assert by_name["global-only"].scope == "global"
assert by_name["project-only"].scope == "project"
def test_find_skill_prefers_project_over_global(tmp_path: Path) -> None:
from my_deepagent.skills import find_skill, project_skills_dir
cfg = load_config(workspace_root=tmp_path, data_dir=tmp_path / "data")
pk = "f0f0f0f0f0f0f0f0"
global_dir = user_skills_dir(cfg)
proj_dir = project_skills_dir(cfg, pk)
global_dir.mkdir(parents=True)
proj_dir.mkdir(parents=True)
_make_skill(global_dir, "dup", description="g")
_make_skill(proj_dir, "dup", description="p")
skill = find_skill(cfg, pk, "dup")
assert skill is not None
assert skill.scope == "project"
assert skill.description == "p"
def test_find_skill_missing_returns_none(tmp_path: Path) -> None:
from my_deepagent.skills import find_skill
cfg = load_config(workspace_root=tmp_path, data_dir=tmp_path / "data")
assert find_skill(cfg, "any-project-key", "nonexistent") is None
# ---------------------------------------------------------------------------
# Integration: build_agent threads skills sources to deepagents
# ---------------------------------------------------------------------------